Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the top level zcl file registration when the gsdk is updated from one branch to another #1347

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fixing the top level zcl file registration when the gsdk is updated from one branch to another #1347

merged 1 commit into from
Jun 26, 2024

Conversation

brdandu
Copy link
Collaborator

@brdandu brdandu commented Jun 24, 2024

  • There is a check for whether a zcl.json or any of its child xml packages being updated. If updated, then the top level package is added again along with its child packages with the is_in_sync column as true for the top level package. However the old top level package's is_in_sync is turned to false to point out an outdated package.
  • All the query-pacakge queries have been updated to use the is_in_sync = 1 package such that the old one is not picked up by mistake.
  • Updated the zap schema, added is_in_sync to package table.
  • JIRA: ZAPP-1079

@brdandu brdandu force-pushed the bug/fixTopLevelZclFileRegistrationWhenPkgsGetUpdated/ZAPP-1079 branch 2 times, most recently from 7464819 to f246ad5 Compare June 25, 2024 18:26
tecimovic
tecimovic reviewed Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@tecimovic tecimovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there would have to be a changed to db-mapping.js somewhere? TO add to the package map the new in-sync column?

src-electron/db/query-package.js Outdated Show resolved Hide resolved
@tecimovic
Copy link
Collaborator

I thought there would have to be a changed to db-mapping.js somewhere? TO add to the package map the new in-sync column?

Oh, right... Maybe you don't even need to query for that explicitely. You just used it implicitely in the queries...

@brdandu
Fixing the top level zcl file registration when the gsdk is updated f…
26feb6e 
…rom one branch to another

- There is a check for whether a zcl.json or any of its child xml packages being updated. If updated, then the top level package is added again along with its child packages with the is_in_sync column as true for the top level package. However the old top level package's is_in_sync is turned to false to point out an outdated package.
- All the query-pacakge queries have been updated to use the is_in_sync = 1 package such that the old one is not picked up by mistake.
- Updated the zap schema, added is_in_sync to package table.
- Adding unit tests for checking gsdk upgrades through xml file updates. Making sure that all zcl packages are reloaded when there is a change to any.
- JRIA: ZAPP-1079
@brdandu brdandu force-pushed the bug/fixTopLevelZclFileRegistrationWhenPkgsGetUpdated/ZAPP-1079 branch from 72c6315 to 26feb6e Compare June 26, 2024 15:14
@brdandu brdandu merged commit 4bd145d into project-chip:master Jun 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecimovic tecimovic tecimovic approved these changes

@paulr34 paulr34 paulr34 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brdandu @tecimovic @paulr34